Discussion:
[Cocci] coccinelle & linux-kernel: unindent blocks by reversing tests?
Joe Perches
2018-03-18 18:25:53 UTC
Permalink
There are many blocks of code that could be
unindented and so neatened by reversing tests.
[]
Which often saves many vertical lines by reducing
now unnecessary line-wrapping done at 80-columns.
I tried it. One can't easily make the transformation when there is a
variable declaration in the block. And Coccinelle doesn't move leading
comments over to the left. Most of the examples I found seemed to have
only one level of opportunity. I don't know if the churn is worth it in
that case. On a more complex example, the pretty printer crashes, so I'll
have to look into that.
[]
[]
---
.../broadcom/brcm80211/brcmsmac/phy/phy_n.c | 455 +++++++++------------
1 file changed, 201 insertions(+), 254 deletions(-)
Dunno about the churn, but converting many lines of badly
wrapped simple statements and reducing line count seems
somewhat worthwhile.

Loading...