[Cocci] Finding and replacing a struct inside another struct

[Luca Coelho]

Hi,
I need some help again. :)
I have a struct (cfg80211_crypto_settings) that contains a new
element
that I want to substitute for a function call
(cfg_control_port_over_nl80211). But this struct appears inside
another struct.
First I try to find a struct that contains the struct I want (with
the
@parent_child@
identifier child;
identifier parent_type;
@@
struct parent_type
{
...
struct cfg80211_crypto_settings child;
...
}

Unfortunately it seems that the parent struct doesn't really match with
this. I guess I'll have to hardcode the parent struct as well.

--
Luca.

[Julia Lawall]

Hi,
I need some help again. :)
I have a struct (cfg80211_crypto_settings) that contains a new element
that I want to substitute for a function call
(cfg_control_port_over_nl80211). But this struct appears inside
another struct.
First I try to find a struct that contains the struct I want (with the
@parent_child@
identifier child;
identifier parent_type;
@@
struct parent_type
{
...
struct cfg80211_crypto_settings child;
...
}
@@
identifier parent_child.child;
identifier parent_child.parent_type;
identifier p;
@@
struct parent_type *p;
<...
-p.child.control_over_nl80211F
+cfg_control_port_over_nl80211(&p.child)
...>
struct parent_type*
warning: line 715: req, previously declared as a metavariable, is used as an identifier
warning: line 732: req, previously declared as a metavariable, is used as an identifier
warning: line 740: req, previously declared as a metavariable, is used as an identifier
warning: line 912: should name_assign_type be a metavariable?
warning: line 918: params, previously declared as a metavariable, is used as an identifier
warning: line 933: params, previously declared as a metavariable, is used as an identifier
warning: line 941: should reqid be a metavariable?
line 1175: non-structure type in field ref
struct parent_type*
warning: line 715: req, previously declared as a metavariable, is used as an identifier
warning: line 732: req, previously declared as a metavariable, is used as an identifier
warning: line 740: req, previously declared as a metavariable, is used as an identifier
warning: line 912: should name_assign_type be a metavariable?
warning: line 918: params, previously declared as a metavariable, is used as an identifier
warning: line 933: params, previously declared as a metavariable, is used as an identifier
warning: line 941: should reqid be a metavariable?
line 1175: non-structure type in field ref
Does anyone know if there is a proper way to do is?

You already found the solution for the actual errors. But it is good to
pay attention to the warnings too. For "should name_assign_type be a
metavariable?" is it concerned because an explicit identifier name is used
as something other than the name of a function or the name of a field. If
you really want to only match assign_type, then you can make a
metavariable-like declaration symbol assign_type; that basically means
that you know what you are doing and don't want to see the warning any
more.

julia

[Julia Lawall]

Post by Luca Coelho

Hi,
I need some help again. :)
I have a struct (cfg80211_crypto_settings) that contains a new
element
that I want to substitute for a function call
(cfg_control_port_over_nl80211). But this struct appears inside
another struct.
First I try to find a struct that contains the struct I want (with
the
@parent_child@
identifier child;
identifier parent_type;
@@
struct parent_type
{
...
struct cfg80211_crypto_settings child;
...
}

Unfortunately it seems that the parent struct doesn't really match with
this. I guess I'll have to hardcode the parent struct as well.

Is this a Coccinelle problem, or is the code just not organized as you
would like. If it is a Coccinelle problem, please send the source code as
well.

thanks,
julia